On Mon, Dec 04, 2017 at 09:05:04PM +0100, Christoffer Dall wrote: > +/* Must be called with irq->irq_lock held */ > +static void vgic_hw_irq_change_active(struct kvm_vcpu *vcpu, struct vgic_irq *irq, > + bool active, bool is_uaccess) > +{ > + if (!is_uaccess) > + irq->active = active;; > + > + if (!is_uaccess) > + vgic_irq_set_phys_active(irq, active); > +} > + Missed one. drew