Re: [Patch v5 6/7] KVM: Enabling guest page hinting via static key

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Nitesh,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on kvm/linux-next]
[also build test ERROR on v4.15-rc1 next-20171128]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/nilal-redhat-com/KVM-Guest-page-hinting/20171129-180331
base:   https://git.kernel.org/pub/scm/virt/kvm/kvm.git linux-next
config: s390-allyesconfig (attached as .config)
compiler: s390x-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=s390 

All errors (new ones prefixed by >>):

   In file included from include/linux/mm.h:10:0,
                    from include/linux/kvm_host.h:17,
                    from arch/s390/kernel/asm-offsets.c:11:
>> include/linux/gfp.h:446:20: error: static declaration of 'arch_alloc_page' follows non-static declaration
    static inline void arch_alloc_page(struct page *page, int order)
                       ^~~~~~~~~~~~~~~
   In file included from arch/s390/include/asm/thread_info.h:24:0,
                    from include/linux/thread_info.h:38,
                    from arch/s390/include/asm/preempt.h:6,
                    from include/linux/preempt.h:81,
                    from include/linux/hardirq.h:5,
                    from include/linux/kvm_host.h:10,
                    from arch/s390/kernel/asm-offsets.c:11:
   arch/s390/include/asm/page.h:140:6: note: previous declaration of 'arch_alloc_page' was here
    void arch_alloc_page(struct page *page, int order);
         ^~~~~~~~~~~~~~~
   In file included from include/linux/mm.h:10:0,
                    from include/linux/kvm_host.h:17,
                    from arch/s390/kernel/asm-offsets.c:11:
   include/linux/gfp.h:453:20: error: static declaration of 'arch_free_page' follows non-static declaration
    static inline void arch_free_page(struct page *page, int order)
                       ^~~~~~~~~~~~~~
   In file included from arch/s390/include/asm/thread_info.h:24:0,
                    from include/linux/thread_info.h:38,
                    from arch/s390/include/asm/preempt.h:6,
                    from include/linux/preempt.h:81,
                    from include/linux/hardirq.h:5,
                    from include/linux/kvm_host.h:10,
                    from arch/s390/kernel/asm-offsets.c:11:
   arch/s390/include/asm/page.h:139:6: note: previous declaration of 'arch_free_page' was here
    void arch_free_page(struct page *page, int order);
         ^~~~~~~~~~~~~~
   make[2]: *** [arch/s390/kernel/asm-offsets.s] Error 1
   make[2]: Target '__build' not remade because of errors.
   make[1]: *** [prepare0] Error 2
   make[1]: Target 'prepare' not remade because of errors.
   make: *** [sub-make] Error 2

vim +/arch_alloc_page +446 include/linux/gfp.h

   442	
   443	#ifdef	CONFIG_KVM_FREE_PAGE_HINTING
   444	#define HAVE_ARCH_ALLOC_PAGE
   445	#define HAVE_ARCH_FREE_PAGE
 > 446	static inline void arch_alloc_page(struct page *page, int order)
   447	{
   448		if (!static_branch_unlikely(&guest_page_hinting_key))
   449			return;
   450		guest_alloc_page(page, order);
   451	}
   452	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux