Re: [Patch v5 5/7] KVM: Sending hyperlist to the host via hinting_vq

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Nitesh,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on kvm/linux-next]
[also build test WARNING on v4.15-rc1 next-20171128]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/nilal-redhat-com/KVM-Guest-page-hinting/20171129-180331
base:   https://git.kernel.org/pub/scm/virt/kvm/kvm.git linux-next
config: i386-randconfig-x016-201748 (attached as .config)
compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   drivers//virtio/virtio_balloon.c: In function 'tell_host_one_page':
>> drivers//virtio/virtio_balloon.c:107:28: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
     u64 gpaddr = virt_to_phys((void *)gvaddr);
                               ^
   drivers//virtio/virtio_balloon.c:110:39: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
     virtqueue_add_chain(vq, id, 0, NULL, (void *)gpaddr, NULL);
                                          ^
   drivers//virtio/virtio_balloon.c: In function 'virtballoon_page_hinting':
>> drivers//virtio/virtio_balloon.c:115:15: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
     u64 gvaddr = (u64)hypervisor_pagelist;
                  ^

vim +107 drivers//virtio/virtio_balloon.c

   101	
   102	#ifdef CONFIG_KVM_FREE_PAGE_HINTING
   103	static void tell_host_one_page(struct virtio_balloon *vb, struct virtqueue *vq,
   104				       u64 gvaddr, int len)
   105	{
   106		unsigned int id = VIRTQUEUE_DESC_ID_INIT;
 > 107		u64 gpaddr = virt_to_phys((void *)gvaddr);
   108	
   109		virtqueue_add_chain_desc(vq, gpaddr, len, &id, &id, 0);
   110		virtqueue_add_chain(vq, id, 0, NULL, (void *)gpaddr, NULL);
   111	}
   112	
   113	void virtballoon_page_hinting(struct virtio_balloon *vb, int hyper_entries)
   114	{
 > 115		u64 gvaddr = (u64)hypervisor_pagelist;
   116	
   117		vb->num_pfns = hyper_entries;
   118		tell_host_one_page(vb, vb->hinting_vq, gvaddr, hyper_entries);
   119	}
   120	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux