On Sun, May 24, 2009 at 09:46:44AM +0300, Dor Laor wrote:
> Gleb Natapov wrote:
>> Signed-off-by: Gleb Natapov <gleb@xxxxxxxxxx>
>> ---
>> target-i386/cpu.h | 1 +
>> target-i386/helper.c | 5 +++--
>> 2 files changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/target-i386/cpu.h b/target-i386/cpu.h
>> index f054af1..29d730e 100644
>> --- a/target-i386/cpu.h
>> +++ b/target-i386/cpu.h
>> @@ -252,6 +252,7 @@
>> #define MSR_IA32_APICBASE 0x1b
>> #define MSR_IA32_APICBASE_BSP (1<<8)
>> #define MSR_IA32_APICBASE_ENABLE (1<<11)
>> +#define MSR_IA32_APICBASE_EXTD (1<<10)
>> #define MSR_IA32_APICBASE_BASE (0xfffff<<12)
>> #define MSR_MTRRcap 0xfe
>> diff --git a/target-i386/helper.c b/target-i386/helper.c
>> index 23efcf4..170c3f7 100644
>> --- a/target-i386/helper.c
>> +++ b/target-i386/helper.c
>> @@ -148,7 +148,7 @@ static x86_def_t x86_defs[] = {
>> CPUID_MTRR | CPUID_CLFLUSH | CPUID_MCA |
>> /* this feature is needed for Solaris and isn't fully implemented */
>> CPUID_PSE36,
>> - .ext_features = CPUID_EXT_SSE3,
>> + .ext_features = CPUID_EXT_SSE3 | CPUID_EXT_X2APIC,
>>
> Why not first test if the feature exists in the kernel?
Correct. This should be done for the final version. This patch series is more
of RFC at this stage.
--
Gleb.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
