Re: [PATCH kvmtool 0/2] Add GICv2m support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/11/17 11:38, Jean-Philippe Brucker wrote:
> GICv2m is an extension to GICv2 defined in the Server Base System
> Architecture (SBSA) [1], allowing pre-GICv3 platforms to support MSIs.
> 
> Presenting GICv2m frames to the guest can be useful for testing PCI
> pass-through on platforms that have a GICv2m, for example AMD Seattle.
> Otherwise they are forced to use legacy INTx.
> 
> This series adds a GICv2m frame to kvmtool, which is basically an MMIO
> register telling the guest which SPIs (Shared Peripheral Interrupts) are
> reserved for MSIs. When configuring MSI vectors, the guest writes the
> desired SPI number into the MSI data field. Then in kvmtool we create
> the IRQFD routes such that they inject the given SPI.
> 
> [1] https://developer.arm.com/products/architecture/a-profile/docs/den0029/latest/server-base-system-architecture
> 
> Jean-Philippe Brucker (2):
>   Prevent segfault when kvm_pause is called too early
>   Add GICv2m support
> 
>  Makefile                                 |   2 +-
>  arm/aarch32/include/asm/kvm.h            |   2 +
>  arm/aarch64/include/asm/kvm.h            |   2 +
>  arm/gic.c                                |  13 +++
>  arm/gicv2m.c                             | 153 +++++++++++++++++++++++++++++++
>  arm/include/arm-common/gic.h             |   3 +
>  arm/include/arm-common/kvm-config-arch.h |   2 +-
>  include/kvm/irq.h                        |  11 +++
>  irq.c                                    |  68 +++++++++++---
>  kvm.c                                    |   2 +-
>  virtio/pci.c                             |   4 +-
>  11 files changed, 245 insertions(+), 17 deletions(-)
>  create mode 100644 arm/gicv2m.c
> 

Thanks for putting this together. For both patches:

Acked-by: Marc Zyngier <marc.zyngier@xxxxxxx>

	M.
-- 
Jazz is not dead. It just smells funny...



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux