On 11/02/17 19:25 -0700, Dan Williams wrote: > On Thu, Nov 2, 2017 at 6:16 PM, Haozhong Zhang <haozhong.zhang@xxxxxxxxx> wrote: > > Signed-off-by: Haozhong Zhang <haozhong.zhang@xxxxxxxxx> > > --- > > include/linux/kvm_host.h | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > > index 6882538eda32..759fe498c89e 100644 > > --- a/include/linux/kvm_host.h > > +++ b/include/linux/kvm_host.h > > @@ -67,6 +67,9 @@ > > #define KVM_PFN_ERR_HWPOISON (KVM_PFN_ERR_MASK + 1) > > #define KVM_PFN_ERR_RO_FAULT (KVM_PFN_ERR_MASK + 2) > > > > +#define kvm_pfn_to_pfn(x) ((pfn_t){ .val = (x)}) > > +#define pfn_to_kvm_pfn(x) ((kvm_pfn_t)((x).val)) > > Shouldn't this mask off the kvm_pfn_t and pfn_t specific bits when > converting between the two? Yes, I'll fix it. Thanks, Haozhong