On 13/10/2017 11:45, Thomas Huth wrote: > On 12.10.2017 10:07, Laurent Vivier wrote: >> Check if we can set the xive server and priority, and >> check we get values that have been set. >> Check we disable/enable interrupts. >> >> This patch also increases NR_CPUS from 8 to 16 >> (maximum for KVM on POWER9, POWER8 allows 96) >> >> Signed-off-by: Laurent Vivier <lvivier@xxxxxxxxxx> >> --- >> Note: I send this as an RFC, because even if this test works well with >> TCG and POWER8 KVM hosts, it detects some problems with POWER9 KVM hosts > > What kind of errors does it detect? Are they expected due to the > different interrupt controllers? > >> main(int argc, char **argv) >> >> check_set_time_of_day(); >> >> + } else if (strcmp(argv[1], "xics") == 0) { >> + > > Superfluous empty line? > >> + check_xics(); >> + This is a standard pattern in kvm-unit-tests: ... } else if (strcmp(argv[1], "XXXX") == 0) { function(...); } else if (strcmp(argv[1], "YYY") == 0) { ... Laurent