On Fri, Oct 13, 2017 at 04:00:18PM +0200, Andrew Jones wrote:
> On Fri, Oct 13, 2017 at 03:17:34PM +0200, Christoffer Dall wrote:
> > We currently allocate an entry dynamically, but we never check if the
> > allocation actually succeeded. We actually don't need a dynamic
> > allocation, because we know the maximum size of an ITS table entry, so
> > we can simply use an allocation on the stack.
> >
> > Cc: <stable@xxxxxxxxxxxxxxx>
> > Signed-off-by: Christoffer Dall <christoffer.dall@xxxxxxxxxx>
> > ---
> > virt/kvm/arm/vgic/vgic-its.c | 18 +++++++-----------
> > 1 file changed, 7 insertions(+), 11 deletions(-)
> >
> > diff --git a/virt/kvm/arm/vgic/vgic-its.c b/virt/kvm/arm/vgic/vgic-its.c
> > index f51c1e1..1d2668b 100644
> > --- a/virt/kvm/arm/vgic/vgic-its.c
> > +++ b/virt/kvm/arm/vgic/vgic-its.c
> > @@ -1801,37 +1801,33 @@ typedef int (*entry_fn_t)(struct vgic_its *its, u32 id, void *entry,
> > static int scan_its_table(struct vgic_its *its, gpa_t base, int size, int esz,
> > int start_id, entry_fn_t fn, void *opaque)
> > {
> > - void *entry = kzalloc(esz, GFP_KERNEL);
> > struct kvm *kvm = its->dev->kvm;
> > unsigned long len = size;
> > int id = start_id;
> > gpa_t gpa = base;
> > + char entry[esz]
>
> Might want a semicolon here :-)
>
Duh, yeah, left out the '-a' in my 'git commit --amend'...
Thanks!
-Christoffer
