Re: [PATCH] KVM: SVM: limit kvm_handle_page_fault to #PF handling

[Brijesh Singh <brijesh.singh@xxxxxxx>]

Hi Paolo,


On 10/10/2017 03:49 AM, Paolo Bonzini wrote:
...

> +
> +static int npf_interception(struct vcpu_svm *svm)
> +{
> +	u64 fault_address = svm->vmcb->control.exit_info_2;
> +	u64 error_code = svm->vmcb->control.exit_info_1;
> +
> +	trace_kvm_page_fault(fault_address, error_code);
> +	return kvm_mmu_page_fault(&svm->vcpu, error_code, fault_address,
                                              ^^^^^^^     ^^^^^

The argument order need to be swapped, second argument should be 
'fault_address' and third 'error_code'

        return kvm_mmu_page_fault(&svm->vcpu, fault_address, error_code,
                         svm->vmcb->control.insn_bytes,
                         svm->vmcb->control.insn_len);


With that fixed.

Reviewed-by: Brijesh Singh <brijesh.singh@xxxxxxx>

thanks