On Sun, Oct 08, 2017 at 08:30:47AM -0500, Brijesh Singh wrote: > Basically we need some variable which is outside the per-device > structure so that we don't end up creating multiple /dev/sev nodes. If > needed, I think we can remove 'has_sev_fops' variable from struct > psp_device if we decide to dynamic alloc 'struct miscdevice sev_misc' in > struct psp_device. The 'has_sev_fops' is mainly used in sev_exit(). If > we decide to dynamic alloc sev_misc then in sev_exit() we can use > psp->sev_misc != NULL instead of psp->has_sev_ops. Yap, that sounds better than an explicit variable. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --