On 11/10/2017 09:50, Ladi Prosek wrote: > To recap, this is what I have in em_rsm() now: > > 1. Go back to real mode - existing code > 2. enter_vmx_non_root_mode() / enter_svm_guest_mode() > 3. rsm_load_state_* - existing code > > Am I just getting lucky or is there a reason why we must have loaded > host state before switching to guest mode? I understand that it would > be cleaner with the intermediate host state load as going directly > from real to guest is kind of unnatural. But it works and saves a > bunch of cycles. Thinking more about it no, it shouldn't be needed. It was just cleaner than the first state load. Paolo