On 10/7/17 9:20 AM, Borislav Petkov wrote: > On Fri, Oct 06, 2017 at 08:06:00PM -0500, Brijesh Singh wrote: >> Add a include file which defines the ioctl and command id used for >> issuing SEV platform management specific commands. >> >> Cc: Paolo Bonzini <pbonzini@xxxxxxxxxx> >> Cc: "Radim Krčmář" <rkrcmar@xxxxxxxxxx> >> Cc: Borislav Petkov <bp@xxxxxxx> >> Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> >> Cc: Gary Hook <gary.hook@xxxxxxx> >> Cc: Tom Lendacky <thomas.lendacky@xxxxxxx> >> Cc: linux-crypto@xxxxxxxxxxxxxxx >> Cc: kvm@xxxxxxxxxxxxxxx >> Cc: linux-kernel@xxxxxxxxxxxxxxx >> Signed-off-by: Brijesh Singh <brijesh.singh@xxxxxxx> >> --- >> include/uapi/linux/psp-sev.h | 115 +++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 115 insertions(+) >> create mode 100644 include/uapi/linux/psp-sev.h > First of all, thanks for splitting the patch - it is much easier to > review this way. > > Then, this patch should be 12.1, i.e., the first of the split because otherwise > the previous one - which should be the next - fails building due to > > drivers/crypto/ccp/psp-dev.c:26:32: fatal error: uapi/linux/psp-sev.h: No such file or directory > #include <uapi/linux/psp-sev.h> > ^ > Just swap them in their order. Ah, yes I will swap the order in next submission. thanks