On 9/29/17 1:54 AM, Borislav Petkov wrote: --- >> Documentation/virtual/kvm/00-INDEX | 3 + >> .../virtual/kvm/amd-memory-encryption.txt | 210 +++++++++++++++++++++ >> 2 files changed, 213 insertions(+) >> create mode 100644 Documentation/virtual/kvm/amd-memory-encryption.txt > Here's a diff which applies ontop of this one, it moves the KVM_SEV_* > commands to Documentation/virtual/kvm/api.txt where they're all together > in one place for obvious advantages. Thank you for the patch. One of feedback in RFC patches was to put the command id and their definitions in amd-memory-encryption.txt hence I was trying to follow that recommendation. Most of ioctls I have seen in api.txt are either common or architecture specific. These commands are vendor specific and I was not sure if they belong to api.txt. I am okay with moving the definition to api.txt in next patch and we can see if kvm folks have any objections. Are you okay if I move the command id definition documentation later in the patch -- basically include it as part of 'KVM: Define SEV key management command id' [1] [1] https://marc.info/?l=kvm&m=150585445223846&w=2 > Also I did some small cleanups while at it. > Notable is that the commands are a smaller number now and > KVM_SEV_RECEIVE_UPDATE_DATA, KVM_SEV_RECEIVE_START and a couple more are > missing. > > On purpose? The series does not implement the migration commands yet hence I took it off.
