Re: [Part1 PATCH v4 12/17] x86/boot: Add early boot support when running with SEV active

Subject: Re: [Part1 PATCH v4 12/17] x86/boot: Add early boot support when running with SEV active
From: Brijesh Singh <brijesh.singh@xxxxxxx>
Date: Tue, 26 Sep 2017 14:10:12 -0500
Cc: brijesh.singh@xxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, x86@xxxxxxxxxx, kvm@xxxxxxxxxxxxxxx, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, "H . Peter Anvin" <hpa@xxxxxxxxx>, Andy Lutomirski <luto@xxxxxxxxxx>, Tom Lendacky <thomas.lendacky@xxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, "Kirill A. Shutemov" <kirill.shutemov@xxxxxxxxxxxxxxx>, Laura Abbott <labbott@xxxxxxxxxx>, Kees Cook <keescook@xxxxxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, Radim Krčmář <rkrcmar@xxxxxxxxxx>
In-reply-to: <20170917144147.GJ4733@nazgul.tnic>
References: <20170916123418.37807-1-brijesh.singh@amd.com> <20170916123418.37807-13-brijesh.singh@amd.com> <20170917144147.GJ4733@nazgul.tnic>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1



On 09/17/2017 09:41 AM, Borislav Petkov wrote:
...

+#ifdef CONFIG_AMD_MEM_ENCRYPT
+	push	%ebx
+	push	%ecx
+	push	%edx
+	push	%edi
+
+	call	1f
+1:	popl	%edi
+	subl	$1b, %edi


32-bit RIP-relative addressing huh? :)

It definitely deserves a comment.


Will add comment in next rev. thanks

-Brijesh

References:
- [Part1 PATCH v4 00/17] x86: Secure Encrypted Virtualization (AMD)
  - From: Brijesh Singh
- [Part1 PATCH v4 12/17] x86/boot: Add early boot support when running with SEV active
  - From: Brijesh Singh
- Re: [Part1 PATCH v4 12/17] x86/boot: Add early boot support when running with SEV active
  - From: Borislav Petkov