On 21/09/2017 08:49, Gerd Hoffmann wrote: > On Wed, 2017-09-20 at 16:50 +0200, David Hildenbrand wrote: >> pflash toggles mr->romd_mode. So this assert does not always hold. >> >> 1) a device was added with !mr->romd_mode, therefore effectively not >> creating a kvm slot as we want to trap every access (add = false). >> 2) mr->romd_mode was toggled on before remove it. There is now >> actually no slot to remove and the asser is wrong. >> >> So let's just drop the assert. > > Works without any obvious bad side effects. > > Tested-by: Gerd Hoffmann <kraxel@xxxxxxxxxx> Queued, thanks. Paolo
