On Wed, Sep 13, 2017 at 11:23:26AM -0500, Brijesh Singh wrote: > I am okay with moving it on the stack but just to give context why > I went in this way. The physical address of data is given to the > device (in this case SEV FW). I was not sure if its okay to pass the > stack address to the device. Why would it not be ok? > Additionally, the FW spec requires us to zero all the fields -- so we > need to memset if we allocate it on the stack. What do you think kzalloc() does internally? :) -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --