On 12.09.2017 17:01, Paolo Bonzini wrote: > On 12/09/2017 16:16, David Hildenbrand wrote: >> I want to use this in another file, so instead of replicating, factoring >> it out feels like the right thing to do. >> >> Let's directly provide it for all architectures, they just have >> to implement get_time_ms() in asm/time.h to use it. >> >> Signed-off-by: David Hildenbrand <david@xxxxxxxxxx> >> --- >> >> The next step would be allowing to add custom parameters to a test. >> (defining them similar to the test cases). >> >> Any other requests/nice to have? Does this make sense? > > It does, but we have at least this, vmx.c (v1 and v2) and vmexit.c, with > not exactly overlapping usecases and command-line syntax. Would it make Yes, the ultimate goal would be to combine all into one. I only had a look at some ARM tests yet. Will have a look at these. > sense to have an API that is not home-grown, e.g. a subset of GTest? > The command-line arguments could be globs (like GTest's "-p"). I'll have a look. Any experts around? > > Paolo -- Thanks, David
