Re: [PATCH v6] kvm: Use a bitmap for tracking used GSIs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Alex Williamson wrote:
Perhaps we should update the bitmap on entry points that everyone uses
so we don't have to worry about preallocating.  We could set the bitmap
in kvm_add_routing_entry() and clear it in kvm_del_routing_entry().
This would mean that kvm_del_routing_entry() implicitly gives up a GSI
obtained via kvm_get_irq_route_gsi(), which seems to be the assumption
already.


Much better.

That would eliminate any need for proliferating KVM_CAP_IRQ_ROUTING
ifdefs or doing anything based on KVM_IOAPIC_NUM_PINS, but should I keep
the KVM_CAP_IRQ_ROUTING around the new code for documentation purposes

Only around code which directly uses the routing facilities (i.e. only in the libkvm wrappers). Code in qemu should only do runtime detection.

I really should write Documentation/kvm/extensions.txt. And ioctls.txt, and intro.txt...

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux