Re: [PATCH v2 2/5] KVM: MMU: check guest CR3 reserved bits based on its physical address width.

[Yu Zhang <yu.c.zhang@xxxxxxxxxxxxxxx>]

On 8/17/2017 8:31 PM, Paolo Bonzini wrote:
> On 17/08/2017 21:52, Yu Zhang wrote:
> > +		if (efer & EFER_LMA) {
> > +			u64 maxphyaddr;
> > +			u32 eax = 0x80000008;
> > +
> > +			if (ctxt->ops->get_cpuid(ctxt, &eax, NULL, NULL, NULL,
> > +						 NO_CHECK_LIMIT)) {
> > +				maxphyaddr = eax & 0xff;
> > +				rsvd = rsvd_bits(maxphyaddr, 62);
> > +			}
> You should use 36 here if ctxt->ops->get_cpuid returns false, for
> consistency with cpuid_query_maxphyaddr.

Oh, right. Thanks! :-)

Yu