On 10/08/2017 19:58, Radim Krčmář wrote: > 2017-08-04 15:14+0200, David Hildenbrand: >> Some cleanups discovered while digging through the code. >> >> David Hildenbrand (13): >> KVM: x86: mmu: returning void in a void function is strange >> KVM: x86: mmu: use for_each_shadow_entry_lockless() >> KVM: x86: mmu: free_page can handle NULL >> KVM: x86: drop BUG_ON(vcpu->kvm) >> KVM: VMX: vmx_vcpu_setup() cannot fail >> KVM: x86: no need to inititalize vcpu members to 0 >> KVM: VMX: drop enable_ept check from ept_sync_context() >> KVM: VMX: call ept_sync_global() with enable_ept only >> KVM: VMX: drop unnecessary function declarations >> KVM: nVMX: no need to set vcpu->cpu when switching vmcs >> KVM: VMX: cleanup init_rmode_identity_map() >> KVM: x86: document special identity map address value >> KVM: x86: allow setting identity map addr with no vcpus only >> >> Documentation/virtual/kvm/api.txt | 4 ++++ >> arch/x86/kvm/mmu.c | 26 ++++++++------------ >> arch/x86/kvm/vmx.c | 50 ++++++++++----------------------------- >> arch/x86/kvm/x86.c | 21 +++++++--------- >> 4 files changed, 35 insertions(+), 66 deletions(-) > > Nice cleanup, > > Reviewed-by: Radim Krčmář <rkrcmar@xxxxxxxxxx> I only had a remark on patch 2, the others look good! Paolo
