Re: [PATCH 6/6] Nested SVM: Improve interrupt injection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 17.05.2009, at 08:48, Gleb Natapov wrote:

On Fri, May 15, 2009 at 10:22:20AM +0200, Alexander Graf wrote:
static void svm_set_irq(struct kvm_vcpu *vcpu, int irq)
{
	struct vcpu_svm *svm = to_svm(vcpu);

-	nested_svm_intr(svm);
+	if(!(svm->vcpu.arch.hflags & HF_GIF_MASK))
+		return;

Why would this function be called if HF_GIF_MASK is not set? This
check is done in svm_interrupt_allowed().

Looks like I was doing something odd - WARN_ON doesn't trigger (which is reasonable).

I think I put the check in when I still had nested_svm_intr() before, because that would unset GIF.

Alex

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux