Re: [PATCH v2 01/11] timekeeper: change interface of clocksource reding functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Denis,

[auto build test ERROR on tip/x86/core]
[cannot apply to v4.13-rc1 next-20170721]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Denis-Plotnikov/make-L2-s-kvm-clock-stable-get-rid-of-pvclock_gtod/20170723-113103
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=sh 

All errors (new ones prefixed by >>):

   drivers/clocksource/timer-sun5i.c: In function 'sun5i_setup_clocksource':
>> drivers/clocksource/timer-sun5i.c:223:18: error: assignment from incompatible pointer type [-Werror=incompatible-pointer-types]
     cs->clksrc.read = sun5i_clksrc_read;
                     ^
   cc1: some warnings being treated as errors

vim +223 drivers/clocksource/timer-sun5i.c

3071efa4 Maxime Ripard 2015-03-31  185  
4a59058f Maxime Ripard 2015-03-31  186  static int __init sun5i_setup_clocksource(struct device_node *node,
4a59058f Maxime Ripard 2015-03-31  187  					  void __iomem *base,
4a59058f Maxime Ripard 2015-03-31  188  					  struct clk *clk, int irq)
4a59058f Maxime Ripard 2015-03-31  189  {
4a59058f Maxime Ripard 2015-03-31  190  	struct sun5i_timer_clksrc *cs;
4a59058f Maxime Ripard 2015-03-31  191  	unsigned long rate;
4a59058f Maxime Ripard 2015-03-31  192  	int ret;
4a59058f Maxime Ripard 2015-03-31  193  
4a59058f Maxime Ripard 2015-03-31  194  	cs = kzalloc(sizeof(*cs), GFP_KERNEL);
4a59058f Maxime Ripard 2015-03-31  195  	if (!cs)
4a59058f Maxime Ripard 2015-03-31  196  		return -ENOMEM;
4a59058f Maxime Ripard 2015-03-31  197  
4a59058f Maxime Ripard 2015-03-31  198  	ret = clk_prepare_enable(clk);
4a59058f Maxime Ripard 2015-03-31  199  	if (ret) {
4a59058f Maxime Ripard 2015-03-31  200  		pr_err("Couldn't enable parent clock\n");
4a59058f Maxime Ripard 2015-03-31  201  		goto err_free;
4a59058f Maxime Ripard 2015-03-31  202  	}
4a59058f Maxime Ripard 2015-03-31  203  
4a59058f Maxime Ripard 2015-03-31  204  	rate = clk_get_rate(clk);
4a59058f Maxime Ripard 2015-03-31  205  
4a59058f Maxime Ripard 2015-03-31  206  	cs->timer.base = base;
4a59058f Maxime Ripard 2015-03-31  207  	cs->timer.clk = clk;
3071efa4 Maxime Ripard 2015-03-31  208  	cs->timer.clk_rate_cb.notifier_call = sun5i_rate_cb_clksrc;
3071efa4 Maxime Ripard 2015-03-31  209  	cs->timer.clk_rate_cb.next = NULL;
3071efa4 Maxime Ripard 2015-03-31  210  
3071efa4 Maxime Ripard 2015-03-31  211  	ret = clk_notifier_register(clk, &cs->timer.clk_rate_cb);
3071efa4 Maxime Ripard 2015-03-31  212  	if (ret) {
3071efa4 Maxime Ripard 2015-03-31  213  		pr_err("Unable to register clock notifier.\n");
3071efa4 Maxime Ripard 2015-03-31  214  		goto err_disable_clk;
3071efa4 Maxime Ripard 2015-03-31  215  	}
4a59058f Maxime Ripard 2015-03-31  216  
4a59058f Maxime Ripard 2015-03-31  217  	writel(~0, base + TIMER_INTVAL_LO_REG(1));
4a59058f Maxime Ripard 2015-03-31  218  	writel(TIMER_CTL_ENABLE | TIMER_CTL_RELOAD,
4a59058f Maxime Ripard 2015-03-31  219  	       base + TIMER_CTL_REG(1));
4a59058f Maxime Ripard 2015-03-31  220  
59387683 Chen-Yu Tsai  2016-10-18  221  	cs->clksrc.name = node->name;
59387683 Chen-Yu Tsai  2016-10-18  222  	cs->clksrc.rating = 340;
59387683 Chen-Yu Tsai  2016-10-18 @223  	cs->clksrc.read = sun5i_clksrc_read;
59387683 Chen-Yu Tsai  2016-10-18  224  	cs->clksrc.mask = CLOCKSOURCE_MASK(32);
59387683 Chen-Yu Tsai  2016-10-18  225  	cs->clksrc.flags = CLOCK_SOURCE_IS_CONTINUOUS;
59387683 Chen-Yu Tsai  2016-10-18  226  
59387683 Chen-Yu Tsai  2016-10-18  227  	ret = clocksource_register_hz(&cs->clksrc, rate);
4a59058f Maxime Ripard 2015-03-31  228  	if (ret) {
4a59058f Maxime Ripard 2015-03-31  229  		pr_err("Couldn't register clock source.\n");
3071efa4 Maxime Ripard 2015-03-31  230  		goto err_remove_notifier;
4a59058f Maxime Ripard 2015-03-31  231  	}
4a59058f Maxime Ripard 2015-03-31  232  
4a59058f Maxime Ripard 2015-03-31  233  	return 0;
4a59058f Maxime Ripard 2015-03-31  234  
3071efa4 Maxime Ripard 2015-03-31  235  err_remove_notifier:
3071efa4 Maxime Ripard 2015-03-31  236  	clk_notifier_unregister(clk, &cs->timer.clk_rate_cb);
4a59058f Maxime Ripard 2015-03-31  237  err_disable_clk:
4a59058f Maxime Ripard 2015-03-31  238  	clk_disable_unprepare(clk);
4a59058f Maxime Ripard 2015-03-31  239  err_free:
4a59058f Maxime Ripard 2015-03-31  240  	kfree(cs);
4a59058f Maxime Ripard 2015-03-31  241  	return ret;
4a59058f Maxime Ripard 2015-03-31  242  }
4a59058f Maxime Ripard 2015-03-31  243  

:::::: The code at line 223 was first introduced by commit
:::::: 593876838826914a7e4e05fbbcb728be6fbc4d89 Revert "clocksource/drivers/timer_sun5i: Replace code by clocksource_mmio_init"

:::::: TO: Chen-Yu Tsai <wens@xxxxxxxx>
:::::: CC: Thomas Gleixner <tglx@xxxxxxxxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux