Re: [PATCH] KVM, pkeys: fix guest pkru save wrong on migration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2017/7/13 17:02, Paolo Bonzini wrote:
On 13/07/2017 10:53, Yang Zhang wrote:

Even if it is restored correctly, you will have the wrong PKRU on the
host between kvm_load_guest_fpu and entering the guest.

Before kvm_load_guest_fpu or after? kvm_load_guest_fpu will load the
right pkru.

It's the right pkru for the guest, but the wrong for the host.  And if
vmx->guest_pkru_valid is true for whatever reason, it will be
overwritten in vmx_vcpu_run.

ok, i see. You want to load guest pkru just before vmentry to avoid the potential conflicts.


Paolo



--
Yang
Alibaba Cloud Computing



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux