Re: [kvm-unit-tests PATCH] VMX controls test framework

[Paolo Bonzini <pbonzini@xxxxxxxxxx>]

On 07/07/2017 01:27, Jim Mattson wrote:
> +	vmcs_write(HOST_RSP, rsp);
> +	__asm__ __volatile__ goto ("vmlaunch" : : : "cc", "memory" : success);

You are putting too much faith in the compiler. :)

I'd rather have the HOST_RSP vmwrite inside the asm, similar to
vmx_enter_guest (and KVM's vmx_vcpu_run).

Otherwise looks good.

Paolo

> +	return false;