On 29/06/2017 19:19, Thomas Huth wrote: > >> x86 cannot use "Wmissing-parameter-type -Wold-style-declaration >> -Woverride-init" only because they're not valid in C++. Maybe we should >> split CFLAGS into COMMON_CCFLAGS and CFLAGS proper, so that CXXFLAGS and >> LDFLAGS can be assigned with >> >> CXXFLAGS += $(COMMON_CCFLAGS) >> LDFLAGS += $(COMMON_CCFLAGS) >> >> Then those three could go in CFLAGS, and the others in COMMON_CCFLAGS. > That's of course a good idea. I'll send a v2 ... FWIW, I also removed -Wtype-limits when applying. Checking against symbolic values that turn out to be zero is pretty common. Paolo
