On 30.06.2017 10:07, Andrew Jones wrote: > On Thu, Jun 29, 2017 at 08:42:52PM +0200, Thomas Huth wrote: >> Using -Wextra together with -Werror is troublesome - various versions >> of GCC produce suspicious or even wrong warnings with -Wextra which >> then become fatal errors with -Werror. For example, the current state >> of the kvm-unit-tests does not compile anymore with GCC 4.8.1 for >> s390x due to an inadequate -Wmissing-field-initializers warning. >> That's annoying for users who just would like to compile the >> kvm-unit-tests and cumbersome for the developers who have to work >> around these problems in the source code. So let's replace -Wextra >> by a saner lists of warning flags that are normally enabled by -Wextra. >> Since they apparently can be used for building x86, too, the flags >> are now also applied to the global CFLAGS instead of specifying them >> for the single targets only. >> >> Signed-off-by: Thomas Huth <thuth@xxxxxxxxxx> >> --- >> v2: >> - Now that we've got COMMON_CFLAGS, the remaining flags can be >> added to the global CFLAGS, too >> - Removed -Wsign-compare >> >> Makefile | 10 +++++++--- >> arm/Makefile.common | 1 - >> powerpc/Makefile.common | 1 - >> s390x/Makefile | 1 - >> 4 files changed, 7 insertions(+), 6 deletions(-) >> >> diff --git a/Makefile b/Makefile >> index 3ef6ea7..f12b2df 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -50,9 +50,11 @@ include $(SRCDIR)/$(TEST_DIR)/Makefile >> cc-option = $(shell if $(CC) $(1) -S -o /dev/null -xc /dev/null \ >> > /dev/null 2>&1; then echo "$(1)"; else echo "$(2)"; fi ;) >> >> -COMMON_CFLAGS += -g >> -COMMON_CFLAGS += $(autodepend-flags) -Wall -Wwrite-strings -Werror >> -frame-pointer-flag=-f$(if $(KEEP_FRAME_POINTER),no-,)omit-frame-pointer >> +COMMON_CFLAGS += -g $(autodepend-flags) >> +COMMON_CFLAGS += -Wall -Wwrite-strings -Wclobbered -Wempty-body -Wuninitialized >> +COMMON_CFLAGS += -Wtype-limits -Wignored-qualifiers -Wunused-but-set-parameter >> +COMMON_CFLAGS += -Werror >> + rame-pointer-flag=-f$(if $(KEEP_FRAME_POINTER),no-,)omit-frame-pointer > > Some finger fumbling here. Ooops, ... very well spotted ... I'll send a v3 Thomas
