On 28.06.2017 14:04, Thomas Huth wrote: > So we make sure that we do not accidentially write to constant "accidentally" (I wouldn't know if Thunderbird wouldn't tell me ;) ) > strings. Also add some missing "const" qualifiers in the code to > avoid that we get compiler warnings now. > > Signed-off-by: Thomas Huth <thuth@xxxxxxxxxx> > --- > This patch supersedes my previous patch "Declare the prefix string > variable in va_report() as const" > > Makefile | 2 +- > lib/report.c | 6 +++--- > x86/msr.c | 4 ++-- > x86/pmu.c | 2 +- > 4 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/Makefile b/Makefile > index 933b9f0..e79cf93 100644 > --- a/Makefile > +++ b/Makefile > @@ -51,7 +51,7 @@ cc-option = $(shell if $(CC) $(1) -S -o /dev/null -xc /dev/null \ > > /dev/null 2>&1; then echo "$(1)"; else echo "$(2)"; fi ;) > > CFLAGS += -g > -CFLAGS += $(autodepend-flags) -Wall -Werror > +CFLAGS += $(autodepend-flags) -Wall -Wwrite-strings -Werror I assume this option has been around for quite some while, so no reasonable gcc will spit fire. Reviewed-by: David Hildenbrand <david@xxxxxxxxxx> -- Thanks, David
