Re: [kvm-unit-tests PATCH] Include util.h to check the prototype with the implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 27.06.2017 07:18, Thomas Huth wrote:
> util.c should include util.h so that the compiler can check that
> the prototype from the header matches the implementation. This is
> required for compiling the file with "-Wmissing-prototypes".

Why is something like that not contained in -Wextra? ;)

> 
> Signed-off-by: Thomas Huth <thuth@xxxxxxxxxx>
> ---
>  lib/util.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/util.c b/lib/util.c
> index 69b1810..a905541 100644
> --- a/lib/util.c
> +++ b/lib/util.c
> @@ -4,6 +4,7 @@
>   * This work is licensed under the terms of the GNU LGPL, version 2.
>   */
>  #include <libcflat.h>
> +#include "util.h"
>  
>  int parse_keyval(char *s, long *val)
>  {
> 

Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>

-- 

Thanks,

David



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux