On Wed, 2017-06-21 at 13:48 +0200, Paolo Bonzini wrote: > On 16/06/2017 15:43, Adalbert Lazar wrote: > > +int kvm_breakpoint(struct kvm_vcpu *vcpu) > > +{ > > + gpa_t gpa; > > + struct kvm_segment cs; > > + > > + kvm_get_segment(vcpu, &cs, VCPU_SREG_CS); > > + gpa = kvm_mmu_gva_to_gpa_read(vcpu, cs.base + > > kvm_rip_read(vcpu), NULL); > > + if (kvmi_breakpoint_event(vcpu, gpa)) > > + return 0; > > + return 1; > > +} > > +EXPORT_SYMBOL_GPL(kvm_breakpoint); > > + > > Please create a separate file with all these functions. > x86.c/vmx.c/svm.c are already too big, let's not make it worse. Noted. Thank you! -- Mihai Donțu