Re: [GIT PULL] Please pull my kvm-ppc-fixes branch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 21/06/2017 01:37, Paul Mackerras wrote:
>> Right, and the arch doesn't even match ... let's forget I asked. :)
>>
>> Pushed into kvm/master, thanks.
> Thanks.
> 
> On a related note, we still have the warning in virt/kvm/kvm_main.c
> for CONFIG_SMP=n builds about the variable 'wait' being unused in
> kvm_make_all_cpus_request(), because smp_call_function_many() doesn't
> reference its 'wait' argument for uniprocessor configs.
> 
> This then causes the build to fail on powerpc because kvm_main.c
> actually gets compiled under arch/powerpc, and we use -Werror for
> arch/powerpc by default.
> 
> Paolo posted a sketch of a patch to make smp_call_function_many be a
> static inline instead of a macro on UP, but it wasn't quite right and
> no-one sent it anywhere.  Paolo, if you're OK with me cleaning it up
> and sending it on, I'll do that.

The problem is that it breaks MIPS, which uses an unused variable.  I'll
send an alternative patch that is confined in KVM.

Paolo



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux