On 08.06.2017 18:24, Paolo Bonzini wrote: > > > On 07/06/2017 21:08, Stefan Raspl wrote: >> Toggle display total number of events by guest (debugfs only). >> If both, tracepoints and debugfs, are in use, a mixture of events (from >> tracepoints) and guests (from debugfs) is displayed. Furthermore, when >> switching to display of events by guest, field filters remain active. >> I.e. the number of events per guest reported considers only events >> matching the filters. Likewise with pid/guest filtering. >> Note that when switching to display of events by guest, DebugfsProvider >> remains to collect data for events as it did before, but the read() >> method summarizes the values by pid. > > Maybe do not enable this command if tracepoints are in use? The idea was to give the user all options available. *I* can't imagine how a mixture of guests and events would be useful, but that doesn't mean that there might be folks out there who can make use of that, still. Plus if we would prevent this command from doing anything when tracepoints are in use, then we should probably give the user some kind of feedback on why nothing changed upon his keypress - but I wouldn't know a place in kvm_stats GUI to do that. So if we leave as is, at least the user gets some immediate feedback and hopefully figure what's going on, and that he might want to rather restart with debugfs only. Ciao, Stefan
