Re: [PATCH v1 14/19] tools/kvm_stat: add new interactive command 'h'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08.06.2017 18:19, Paolo Bonzini wrote:
> 
> 
> On 07/06/2017 21:08, Stefan Raspl wrote:
>> +        """Display help with list of interactive commands"""
>> +        msg = ('   c     clear filter',
>> +               '   f     filter by regular expression',
>> +               '   g     filter by guest name',
>> +               '   h     display interactive commands reference',
>> +               '   p     filter by PID',
>> +               '   q     quit',
>> +               '   r     reset stats',
>> +               '   x     toggle reporting of stats for individual child trace'
>> +               ' events',
>> +               'Any other key refreshes statistics immediately')
> 
>> @@ -1237,10 +1263,11 @@ description_text = """
>>     c     clear filter
>>     f     filter by regular expression
>>     g     filter by guest name
>> +   h     display interactive commands reference
>>     p     filter by PID
>>     q     quit
>> -   x     toggle reporting of stats for individual child trace events
>>     r     reset stats
>> +   x     toggle reporting of stats for individual child trace events
>>  Press any other key to refresh statistics immediately.
>>  """
> 
> Some duplication here... want to eliminate it as a follow-up patch, by
> creating a global string or array for this part of description_text?

I was annoyed by this, too. Couldn't figure an obvious way
immediately to re-use the string, will give it some more thought.

Ciao,
Stefan




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux