On Thu, Jun 15, 2017 at 06:45:28PM +0200, Andrew Jones wrote:
> On Thu, Jun 15, 2017 at 06:08:12PM +0300, Roman Kagan wrote:
> > Add a test for Hyper-V message and event connections.
> >
> > It requires QEMU with the extended test device supporting message end
> > event connection test modes (recently posted on qemu-devel). On older
> > QEMU versions the test reports a single SKIP.
> >
> > Signed-off-by: Roman Kagan <rkagan@xxxxxxxxxxxxx>
> > ---
> > v1 -> v2:
> > - dropped already applied patches
> > - add detection of old QEMU per Paolo's suggestion and skip the test if QEMU
> > doesn't support connectionid
> > - adjusted test group in unittests.cfg
> > - fixed indentation to use tabs as it's a new file
> > - note: *not* switched to on_cpus() because different arguments are passed to
> > each cpu
>
> Not a big deal, but you probably could have used on_cpus() for setup_cpu
> and teardown_cpu.
Indeed. I didn't notice because those are run synchronously in the
current code, but on_cpus() would be fine for them, too.
> If you do need to respin, then I also saw a white space
> issue that I pointed out below. Also, while on the topic of style, we
> prefer not to use {} for one line if's and while's.
Yes, will fix, thanks. (I keep getting confused about which style --
QEMU or Linux -- is in use at the moment. :)
Roman.
