Re: [kvm-unit-tests PATCH v2 1/9] configure: make it run-able from outside source tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 17/05/2017 16:50, Radim Krčmář wrote:
>>  # create the config
>>  cat <<EOF > config.mak
>> +SRCDIR=$srcdir
> Whitespace in $srcdir is going to break the build.

I think it's pretty common to have things break horribly if there's
whitespace in $srcdir.

Just don't call your srcdir "little bobby tables; rm -rf /".

Paolo

  I think that we
> cannot prevent that by escaping as `make` is notoriously bad in that
> regard.  Aborting sounds better and maybe something like this could
> work:
> 
>   ln -sf "$srcdir" srcdir
>   srcdir=srcdir
> 
> I'm ok with this version if the solution would not be simple. :)



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux