On 08/06/17 22:45, Murilo Opsfelder Araújo wrote: > On 06/08/2017 08:41 AM, Michael Ellerman wrote: >> Alexey Kardashevskiy <aik@xxxxxxxxx> writes: >> >>> Hi, >>> >>> How did you manage to have CONFIG_EEH=y and CONFIG_VFIO_SPAPR_EEH=n? "make >>> oldconfig" fixes this to CONFIG_VFIO_SPAPR_EEH=y. >> >> Hmm, Murilo did you confirm the bug still happens on upstream with that >> rand config? > > Yes, it's still happening with next-20170607. The config you attached in the first mail has CONFIG_VFIO_SPAPR_EEH=m, here is my confusion. The config from the link below does not have KVM_BOOK3S_64 which selects SPAPR_TCE_IOMMU and which in turn selects VFIO_IOMMU_SPAPR_TCE. So https://github.com/0day-ci/linux/commit/36ed1ddb05e132aa3cfbb610f0f8402a0774da12 looks correct. > > For me, `make oldconfig` hasn't changed it to CONFIG_VFIO_SPAPR_EEH=y. See: > > $ git clean -dfxq > $ git reset --hard origin/master > HEAD is now at 8d1b80c Add linux-next specific files for 20170607 > > $ curl http://kisskb.ellerman.id.au/kisskb/buildresult/12982362/config/ -o .config > $ grep -E 'EEH|SPAPR' .config > CONFIG_EEH=y > # CONFIG_SPAPR_TCE_IOMMU is not set > > $ yes '' | make oldconfig > > $ grep -E 'EEH|SPAPR' .config > CONFIG_EEH=y > # CONFIG_SPAPR_TCE_IOMMU is not set > > $ make -j 160 ARCH=powerpc > ... > drivers/vfio/pci/vfio_pci.o: In function `.vfio_pci_release': > vfio_pci.c:(.text+0xa98): undefined reference to `.vfio_spapr_pci_eeh_release' > drivers/vfio/pci/vfio_pci.o: In function `.vfio_pci_open': > vfio_pci.c:(.text+0x1420): undefined reference to `.vfio_spapr_pci_eeh_open' > make: *** [vmlinux] Error 1 > -- Alexey
