On 06/06/17 13:44, Christoffer Dall wrote: > On Thu, Jun 01, 2017 at 11:21:09AM +0100, Marc Zyngier wrote: >> Now that we're able to safely handle Group-0 sysreg access, let's >> give the user the opportunity to enable it by passing a specific >> command-line option (vgic_v3.group0_trap). >> >> Signed-off-by: Marc Zyngier <marc.zyngier@xxxxxxx> >> --- >> virt/kvm/arm/vgic/vgic-v3.c | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/virt/kvm/arm/vgic/vgic-v3.c b/virt/kvm/arm/vgic/vgic-v3.c >> index 7525216ef988..1486ce25edcb 100644 >> --- a/virt/kvm/arm/vgic/vgic-v3.c >> +++ b/virt/kvm/arm/vgic/vgic-v3.c >> @@ -419,6 +419,12 @@ int vgic_v3_map_resources(struct kvm *kvm) >> >> DEFINE_STATIC_KEY_FALSE(vgic_v3_cpuif_trap); >> >> +static int __init early_group0_trap_cfg(char *buf) >> +{ >> + return strtobool(buf, &group0_trap); >> +} >> +early_param("vgic_v3.group0_trap", early_group0_trap_cfg); >> + > > same comment as before, if this should be called something with KVM. > > Also, btw., what's the policy on adding new kernel parameters? Should > they be documented in kernel-parameters.txt or is that auto-generated > these days? I guess I should add something indeed. Thanks, M. -- Jazz is not dead. It just smells funny...