Re: [kvm-unit-tests PATCH v2 3/6] s390x: copy sclp.h and sclp-ascii.c from QEMU

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 19.05.2017 11:32, Thomas Huth wrote:
> On 18.05.2017 13:34, David Hildenbrand wrote:
>> The s390x-ccw pcbios already has what we need to print to the sclp
>> console. Let's copy the files and adjust them to our needs later.
>>
>> Signed-off-by: David Hildenbrand <david@xxxxxxxxxx>
>> ---
>>  lib/s390x/sclp-ascii.c |  82 +++++++++++++++++++++++++++++++++++++
>>  lib/s390x/sclp.h       | 107 +++++++++++++++++++++++++++++++++++++++++++++++++
>>  2 files changed, 189 insertions(+)
>>  create mode 100644 lib/s390x/sclp-ascii.c
>>  create mode 100644 lib/s390x/sclp.h
>>
>> diff --git a/lib/s390x/sclp-ascii.c b/lib/s390x/sclp-ascii.c
>> new file mode 100644
>> index 0000000..dc1c3e4
>> --- /dev/null
>> +++ b/lib/s390x/sclp-ascii.c
> 
> Looks like the file has been renamed to sclp.c in recent QEMU master ...
> maybe we should use that name here, too?
> 

At the time I copied it, it was called sclp-ascii.c, so this should be
fine I think. Also, if we ever add new code related to sclp, we will
rather put it into a new file, which could then become sclp.c

>  Thomas
> 

Thanks


-- 

Thanks,

David



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux