On Wed, May 13, 2009 at 06:19:35AM -0600, Alex Williamson wrote: > On Wed, 2009-05-13 at 10:04 +0300, Michael S. Tsirkin wrote: > > On Tue, May 12, 2009 at 04:07:15PM -0600, Alex Williamson wrote: > > > @@ -286,6 +289,9 @@ kvm_context_t kvm_init(struct kvm_callbacks *callbacks, > > > int fd; > > > kvm_context_t kvm; > > > int r; > > > +#ifdef KVM_CAP_IRQ_ROUTING > > > > Let's kill all these ifdefs. Or at least, let's not add them. > > AFAICT, they're still used both for builds against older kernels and > architectures that don't support it. architectures only, I think. you don't know what kernel you will run on, at build time. > Hollis just added the one around > kvm_get_irq_route_gsi() 10 days ago to fix ppc build. Has it since been > deprecated? Thanks, > > Alex > These should be local to libkvm I think. I think kvm_get_gsi_count already returns an error on ppc, so things should work without ifdefs. -- MST -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
