On Fri, 12 May 2017 15:59:29 -0600 Alex Williamson <alex.williamson@xxxxxxxxxx> wrote: > > + if (pasidt_binfo->size >= intel_iommu_get_pts(iommu)) { > > + pr_err("Invalid gPASID table size %llu, host size > > %lu\n", > > + pasidt_binfo->size, > > + intel_iommu_get_pts(iommu)); > > + ret = -EINVAL; > > + goto out; > > equal is not valid? you are right, equal is valid. I was thinking of shared PASID space between guest and host but that is not the case here. The rest of your comments are taken too, thanks for the review. Jacob