Re: [kvm-unit-tests PATCH v1 2/3] ppc64: use asm-generic spinlock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12.05.2017 12:20, David Hildenbrand wrote:
> Since the ppc64 implementation is currently only a defunc dummy
> implementation, let's replace it by the generic one.
> 
> Signed-off-by: David Hildenbrand <david@xxxxxxxxxx>
> ---
>  lib/ppc64/asm/spinlock.h |  9 ++-------
>  lib/ppc64/spinlock.c     | 18 ------------------
>  powerpc/Makefile.ppc64   |  1 -
>  3 files changed, 2 insertions(+), 26 deletions(-)
>  delete mode 100644 lib/ppc64/spinlock.c
> 
> diff --git a/lib/ppc64/asm/spinlock.h b/lib/ppc64/asm/spinlock.h
> index 002cdb1..da1d9d0 100644
> --- a/lib/ppc64/asm/spinlock.h
> +++ b/lib/ppc64/asm/spinlock.h
> @@ -1,11 +1,6 @@
> +#include <asm-generic/spinlock.h>

In case you respin this series: I think it would be nicer to put the
#include within the header guards below.

>  #ifndef _ASMPPC64_SPINLOCK_H_
>  #define _ASMPPC64_SPINLOCK_H_
>  
> -struct spinlock {
> -	int v;
> -};
> -
> -extern void spin_lock(struct spinlock *lock);
> -extern void spin_unlock(struct spinlock *lock);
> -
>  #endif /* _ASMPPC64_SPINLOCK_H_ */

Acked-by: Thomas Huth <thuth@xxxxxxxxxx>




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux