On 04/20/2017 07:09 AM, Daniel P. Berrange wrote: >>> +++ b/qapi/event.json >>> @@ -10,6 +10,10 @@ >>> # Emitted when the virtual machine has shut down, indicating that qemu is >>> # about to exit. >>> # >>> +# @guest: If true, the shutdown was triggered by a guest request (such as >>> +# executing a halt instruction) rather than a host request (such as sending >>> +# qemu a SIGINT). (since 2.10) >>> +# >> >> "executing a halt instruction" suggests "halt" is a machine instruction. Which is indeed what most of the places I patched to pass 'true' are emulating - the machine halt instruction. >> I think you mean /usr/sbin/halt. Suggest something like "executing a >> halt command". > > Well technically /usr/sbin/halt just terminates all processes / kernel and > halts CPUs, but the virtual machine is still active (and a 'reset' in the > monitor can start it again. /usr/sbin/poweroff is what actually does the > ACPI poweroff to trigger QEMU to exit[1] I'm thinking of this wording: triggered by a guest request (such as the guest running /usr/sbin/poweroff to trigger an ACPI shutdown or machine halt instruction) -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
