2017-04-06 12:18+0200, Christian Borntraeger: > On 03/31/2017 06:06 PM, Andrew Jones wrote: >> Signed-off-by: Andrew Jones <drjones@xxxxxxxxxx> >> +VCPU Requests and Guest Mode >> +============================ > > FWIW, s390 does not implement the guest mode. Maybe add some words that not > all architectures implement that? Or do we expect Radims rework soon? Yes, mention that it is an optional optimization sounds good. I won't be adding guest->mode to s390 (at least in the beginning). This means that kvm_arch_vcpu_should_kick() should return true. In kvm_make_all_cpus_request(), there is kvm_vcpu_exiting_guest_mode(vcpu) != OUTSIDE_GUEST_MODE that ought to be replaced with kvm_arch_vcpu_should_kick(), and it should return true if the arch doesn't implement guest->mode. But on s390, the condition currently always returns false ... is that IPI-less behavior of kvm_make_all_cpus_request intended on s390? Thanks.
