Re: [PATCH v2 6/9] KVM: arm/arm64: use a vcpu request on irq injection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 04/04/2017 19:42, Christoffer Dall wrote:
> 
> this is not going to be called when we don't have the vgic, which means
> that if vcpu_interrupt_line() is used as you modify it above, the
> request will never get cleared.

Heh, I'll stop pretending I can give positive reviews of ARM patches and
keep bash^Wproviding constructive criticism. :)

In fact, I forgot to add that x86 recently moved to request-less
kvm_vcpu_kick when hardware interrupt injection is available.  This was
after I noticed that requests were just used as a workaround for
incorrect ordering of local_irq_disable, vcpu->mode=IN_GUEST_MODE, and
so on.

Paolo



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux