On Tue, Apr 04, 2017 at 05:30:14PM +0200, Christoffer Dall wrote: > On Fri, Mar 31, 2017 at 06:06:50PM +0200, Andrew Jones wrote: > > From: Radim Krčmář <rkrcmar@xxxxxxxxxx> > > > > A first step in vcpu->requests encapsulation. > > Could we have a note here on why we need to access vcpu->requests using > READ_ONCE now? Sure, maybe we should put the note as a comment above the read in kvm_request_pending(). Something like /* * vcpu->requests reads may appear in sequences that have strict * data or control dependencies. Use READ_ONCE() to ensure the * compiler does not do anything that breaks the required ordering. */ Radim? Thanks, drew
