From: "Reshetova, Elena" <elena.reshetova@xxxxxxxxx> Date: Mon, 3 Apr 2017 07:28:01 +0000 > >> From: Elena Reshetova <elena.reshetova@xxxxxxxxx> >> Date: Mon, 20 Feb 2017 13:06:20 +0200 >> >> > refcount_t type and corresponding API should be >> > used instead of atomic_t when the variable is used as >> > a reference counter. This allows to avoid accidental >> > refcounter overflows that might lead to use-after-free >> > situations. >> > >> > Signed-off-by: Elena Reshetova <elena.reshetova@xxxxxxxxx> >> > Signed-off-by: Hans Liljestrand <ishkamiel@xxxxxxxxx> >> > Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx> >> > Signed-off-by: David Windsor <dwindsor@xxxxxxxxx> >> >> Acked-by: David S. Miller <davem@xxxxxxxxxxxxx> > > Hi David, > > Would you be able to propagate this patch further or should I send > it (with your acked-by) once more to specific list/maintainer for > the inclusion? I'm generally not happy with the refcount_t and the added overhead it has compared to the existing atomic_t operations. I know it is going to make a difference for networking. I understand that this sparc case is a slow path, but I know that if we just apply all of these refcount_t conversions, there will be no work done to address the performance issues. So I'm reluctant to ACK in any way these refcount_t conversions, sorry.
