[vhost:linux-next 6/19] drivers//remoteproc/remoteproc_virtio.c:106:7: error: too few arguments to function 'vring_new_virtqueue'

kbuild test robot <fengguang.wu@xxxxxxxxx · Thu, 30 Mar 2017 06:53:51 +0800

   tree:   .config.gzDescription: application/gzip

sbygoogle.js"> oc/remoteproc_virtio.c:106:7: error: too few arguments to function 'vring_new_virtqueue' > virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx this_widget.js#pubid=ra-5196c2ae1be43d18"> sbygoogle.js"> b/scm/linux/kernel/git/mst/vhost.git">https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next virtio: add context flag to find vqs 'rp_find_vq': warning: passing argument 8 of 'vring_new_virtqueue' from incompatible pointer type c:25:0: (*)(struct virtqueue *)' but argument is of type 'void (*)(struct virtqueue *)' passing argument 9 of 'vring_new_virtqueue' from incompatible pointer type c:25:0: (*)(struct virtqueue *)' but argument is of type 'const char *' error: too few arguments to function 'vring_new_virtqueue' vdev, false, addr, c:25:0: warning: initialization from incompatible pointer type (near initialization for 'rproc_virtio_config_ops.find_vqs') irtio.c 2012-02-13  100  		id, addr, len, rvring->notifyid); 2011-10-20  101 2012-01-12  102  	/* 2012-01-12  103  	 * Create the new vq, and tell virtio we're not interested in 2012-01-12  104  	 * the 'weak' smp barriers, since we're talking with a real device. 2012-01-12  105  	 */ 2012-08-28 @106  	vq = vring_new_virtqueue(id, len, rvring->align, vdev, false, addr, 2011-10-20 @107  				 rproc_virtio_notify, callback, name); 2011-10-20  108  	if (!vq) { 2012-05-30  109  		dev_err(dev, "vring_new_virtqueue %s failed\n", name); 2012-05-17  110  		rproc_free_vring(rvring); 2012-02-13  111  		return ERR_PTR(-ENOMEM); 2011-10-20  112  	} 2011-10-20  113 2012-02-13  114  	rvring->vq = vq; 2012-02-13  115  	vq->priv = rvring; 2011-10-20  116 2011-10-20  117  	return vq; 2011-10-20  118  } 2011-10-20  119 2012-11-12  120  static void __rproc_virtio_del_vqs(struct virtio_device *vdev) 2011-10-20  121  { 2011-10-20  122  	struct virtqueue *vq, *n; 2012-02-13  123  	struct rproc_vring *rvring; 2011-10-20  124 2011-10-20  125  	list_for_each_entry_safe(vq, n, &vdev->vqs, list) { 2012-02-13  126  		rvring = vq->priv; 2012-02-13  127  		rvring->vq = NULL; 2011-10-20  128  		vring_del_virtqueue(vq); 2011-10-20  129  	} 2011-10-20  130  } 2011-10-20  131 2012-11-12  132  static void rproc_virtio_del_vqs(struct virtio_device *vdev) 2012-11-12  133  { 2012-11-12  134  	__rproc_virtio_del_vqs(vdev); 2012-11-12  135  } 2012-11-12  136 2016-08-12  137  static int rproc_virtio_find_vqs(struct virtio_device *vdev, unsigned int nvqs, 2011-10-20  138  				 struct virtqueue *vqs[], 2011-10-20  139  				 vq_callback_t *callbacks[], 2017-02-05  140  				 const char * const names[], 2017-02-05  141  				 struct irq_affinity *desc) 2011-10-20  142  { 2011-10-20  143  	int i, ret; 2011-10-20  144 2011-10-20  145  	for (i = 0; i < nvqs; ++i) { 2011-10-20  146  		vqs[i] = rp_find_vq(vdev, i, callbacks[i], names[i]); 2011-10-20  147  		if (IS_ERR(vqs[i])) { 2011-10-20  148  			ret = PTR_ERR(vqs[i]); 2011-10-20  149  			goto error; 2011-10-20  150  		} 2011-10-20  151  	} 2011-10-20  152 2011-10-20  153  	return 0; 2011-10-20  154 2011-10-20  155  error: 2012-11-12  156  	__rproc_virtio_del_vqs(vdev); 2011-10-20  157  	return ret; 2011-10-20  158  } 2011-10-20  159 2011-10-20  160  static u8 rproc_virtio_get_status(struct virtio_device *vdev) 2011-10-20  161  { 2013-02-21  162  	struct rproc_vdev *rvdev = vdev_to_rvdev(vdev); 2013-02-21  163  	struct fw_rsc_vdev *rsc; 2013-02-21  164 2013-02-21  165  	rsc = (void *)rvdev->rproc->table_ptr + rvdev->rsc_offset; 2013-02-21  166 2013-02-21  167  	return rsc->status; 2011-10-20  168  } 2011-10-20  169 2011-10-20  170  static void rproc_virtio_set_status(struct virtio_device *vdev, u8 status) 2011-10-20  171  { 2013-02-21  172  	struct rproc_vdev *rvdev = vdev_to_rvdev(vdev); 2013-02-21  173  	struct fw_rsc_vdev *rsc; 2013-02-21  174 2013-02-21  175  	rsc = (void *)rvdev->rproc->table_ptr + rvdev->rsc_offset; 2013-02-21  176 2013-02-21  177  	rsc->status = status; 2012-02-13  178  	dev_dbg(&vdev->dev, "status: %d\n", status); 2011-10-20  179  } 2011-10-20  180 2011-10-20  181  static void rproc_virtio_reset(struct virtio_device *vdev) 2011-10-20  182  { 2013-02-21  183  	struct rproc_vdev *rvdev = vdev_to_rvdev(vdev); 2013-02-21  184  	struct fw_rsc_vdev *rsc; 2013-02-21  185 2013-02-21  186  	rsc = (void *)rvdev->rproc->table_ptr + rvdev->rsc_offset; 2013-02-21  187 2013-02-21  188  	rsc->status = 0; 2011-10-20  189  	dev_dbg(&vdev->dev, "reset !\n"); 2011-10-20  190  } 2011-10-20  191 2011-10-20  192  /* provide the vdev features as retrieved from the firmware */ S. Tsirkin 2014-10-07  193  static u64 rproc_virtio_get_features(struct virtio_device *vdev) 2011-10-20  194  { 2012-02-13  195  	struct rproc_vdev *rvdev = vdev_to_rvdev(vdev); 2013-02-21  196  	struct fw_rsc_vdev *rsc; 2013-02-21  197 2013-02-21  198  	rsc = (void *)rvdev->rproc->table_ptr + rvdev->rsc_offset; 2011-10-20  199 2013-02-21  200  	return rsc->dfeatures; 2011-10-20  201  } 2011-10-20  202 S. Tsirkin 2014-12-04  203  static int rproc_virtio_finalize_features(struct virtio_device *vdev) 2011-10-20  204  { 2012-02-13  205  	struct rproc_vdev *rvdev = vdev_to_rvdev(vdev); 2013-02-21  206  	struct fw_rsc_vdev *rsc; 2013-02-21  207 2013-02-21  208  	rsc = (void *)rvdev->rproc->table_ptr + rvdev->rsc_offset; 2011-10-20  209 2011-10-20  210  	/* Give virtio_ring a chance to accept features */ 2011-10-20  211  	vring_transport_features(vdev); 2011-10-20  212 S. Tsirkin 2014-11-27  213  	/* Make sure we don't have any features > 32 bits! */ S. Tsirkin 2014-11-27  214  	BUG_ON((u32)vdev->features != vdev->features); S. Tsirkin 2014-11-27  215 2011-10-20  216  	/* 2011-10-20  217  	 * Remember the finalized features of our vdev, and provide it 2011-10-20  218  	 * to the remote processor once it is powered on. 2011-10-20  219  	 */ S. Tsirkin 2014-10-07  220  	rsc->gfeatures = vdev->features; S. Tsirkin 2014-12-04  221 S. Tsirkin 2014-12-04  222  	return 0; 2013-02-21  223  } 2013-02-21  224 2016-08-12  225  static void rproc_virtio_get(struct virtio_device *vdev, unsigned int offset, 2016-08-12  226  			     void *buf, unsigned int len) 2013-02-21  227  { 2013-02-21  228  	struct rproc_vdev *rvdev = vdev_to_rvdev(vdev); 2013-02-21  229  	struct fw_rsc_vdev *rsc; 2013-02-21  230  	void *cfg; 2013-02-21  231 2013-02-21  232  	rsc = (void *)rvdev->rproc->table_ptr + rvdev->rsc_offset; 2013-02-21  233  	cfg = &rsc->vring[rsc->num_of_vrings]; 2013-02-21  234 2013-02-21  235  	if (offset + len > rsc->config_len || offset + len < len) { 2013-02-21  236  		dev_err(&vdev->dev, "rproc_virtio_get: access out of bounds\n"); 2013-02-21  237  		return; 2013-02-21  238  	} 2013-02-21  239 2013-02-21  240  	memcpy(buf, cfg + offset, len); 2013-02-21  241  } 2013-02-21  242 2016-08-12  243  static void rproc_virtio_set(struct virtio_device *vdev, unsigned int offset, 2016-08-12  244  			     const void *buf, unsigned int len) 2013-02-21  245  { 2013-02-21  246  	struct rproc_vdev *rvdev = vdev_to_rvdev(vdev); 2013-02-21  247  	struct fw_rsc_vdev *rsc; 2013-02-21  248  	void *cfg; 2013-02-21  249 2013-02-21  250  	rsc = (void *)rvdev->rproc->table_ptr + rvdev->rsc_offset; 2013-02-21  251  	cfg = &rsc->vring[rsc->num_of_vrings]; 2013-02-21  252 2013-02-21  253  	if (offset + len > rsc->config_len || offset + len < len) { 2013-02-21  254  		dev_err(&vdev->dev, "rproc_virtio_set: access out of bounds\n"); 2013-02-21  255  		return; 2013-02-21  256  	} 2013-02-21  257 2013-02-21  258  	memcpy(cfg + offset, buf, len); 2011-10-20  259  } 2011-10-20  260 2013-02-10  261  static const struct virtio_config_ops rproc_virtio_config_ops = { 2011-10-20  262  	.get_features	= rproc_virtio_get_features, 2011-10-20  263  	.finalize_features = rproc_virtio_finalize_features, 2011-10-20 @264  	.find_vqs	= rproc_virtio_find_vqs, 2011-10-20  265  	.del_vqs	= rproc_virtio_del_vqs, 2011-10-20  266  	.reset		= rproc_virtio_reset, 2011-10-20  267  	.set_status	= rproc_virtio_set_status, move queue_index to vring_virtqueue Technology Center all">https://lists.01.org/pipermail/kbuild-all                   Intel Corporation >