Re: [kvm-unit-tests PATCH v4 0/2] powerpc: Test SPR persistency during migration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/22/2017 04:20 PM, Laurent Vivier wrote:
> On 22/03/2017 09:28, Thomas Huth wrote:
>> Here's a KVM-unit-test to check the persistency of SPRs during migration.
>> First patch adds a helper script for doing migration tests in the
>> kvm-unit-test framework, and the second patch contains the SPR tester.
>>
>> v4:
>> - Fix the error paths in run_migration() - use "exit 2" instead of "exit 1"
>>   to avoid trouble with the return code magic in the powerpc/run script
>>   and make sure to terminate the two QEMU instances in case of migration
>>   failure.
>>
>> v3:
>> - Migration shell script code has been moved to a helper function in
>>   arch-run.bash, so that this now also works with the standalone tests.
>> - Introduced the helper function migration_cmd there, too, so that other
>>   architectures can use this, too.
>> - Use "$@" instead of $* when calling QEMU.
>>
>> v2:
>> - Addressed review feedback from v1
>> - Now using cpu_relax() instead of asm volatile ("nop")
>>
>> Thomas Huth (2):
>>   Add the possibility to do simple migration tests
>>   powerpc: Add Special Purpose Register persistency test
>>
>>  powerpc/Makefile.common |   3 +-
>>  powerpc/cstart64.S      |   2 +
>>  powerpc/run             |   2 +-
>>  powerpc/sprs.c          | 304 ++++++++++++++++++++++++++++++++++++++++++++++++
>>  powerpc/unittests.cfg   |   5 +
>>  scripts/arch-run.bash   |  63 ++++++++++
>>  scripts/runtime.bash    |   3 +
>>  7 files changed, 380 insertions(+), 2 deletions(-)
>>  create mode 100644 powerpc/sprs.c
>>
> 
> Really nice work.

Yes. 

I hope to have some time to hack a little your script to use 
a minimal image with a guest agent and do a ping to check that 
migration has succeeded. That would increase the scope of what 
is being migrated. Good for regression tests, specially when
we are modifying the interrupt or mmu models.   

Thanks,

C. 

> I've tested with TCG and KVM HV and it works fine.
> 
> It hangs with KVM PR, but I have an "emulation at f60 failed (00000000)"
> in kernel logs, did you see that?
> 
> Laurent
> 




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux