On 15.03.2017 09:01, Peter Xu wrote: > We have specific destructors for pic/ioapic, we'd better use them when > destroying the VM as well. > > Signed-off-by: Peter Xu <peterx@xxxxxxxxxx> > --- > arch/x86/kvm/x86.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index 1faf620..d30ff49 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -8153,8 +8153,8 @@ void kvm_arch_destroy_vm(struct kvm *kvm) > if (kvm_x86_ops->vm_destroy) > kvm_x86_ops->vm_destroy(kvm); > kvm_iommu_unmap_guest(kvm); > - kfree(kvm->arch.vpic); > - kfree(kvm->arch.vioapic); > + kvm_pic_destroy(kvm); > + kvm_ioapic_destroy(kvm); > kvm_free_vcpus(kvm); > kvfree(rcu_dereference_check(kvm->arch.apic_map, 1)); > kvm_mmu_uninit_vm(kvm); > Reviewed-by: David Hildenbrand <david@xxxxxxxxxx> -- Thanks, David