Re: [PATCH v15 6/9] x86/arch_prctl: Add ARCH_[GET|SET]_CPUID

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 16, 2017 at 4:09 AM, Michael Ellerman <mpe@xxxxxxxxxxxxxx> wrote:
> Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> writes:
>
>> Kyle,
>>  your patch format is really odd.
>>
>> You seem to have *eight* lines of context rather than the regular 3.
>> Is there any reason for that oddity?
>>
>> It basically means that a one-line hunk ends up being 17 lines of
>> unified diff rather than 7.
>
> Presumably he's done:
>
> $ git config diff.context 8
>
>
> Which I also did at one point because I thought it might help for
> reading diffs, but reverted after realising it also affects the diffs
> that are generated by format-patch etc.
>
> cheers

Indeed.  In my case it dates back to my days hacking on Firefox, which
wants 8 lines of context for patches.  I'll remove it.

- Kyle



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux