Re: [PATCH v1 16/22] KVM: x86: drop goto label in kvm_set_routing_entry()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v1 16/22] KVM: x86: drop goto label in kvm_set_routing_entry()
From: Peter Xu <peterx@xxxxxxxxxx>
Date: Wed, 15 Mar 2017 16:23:29 +0800
Cc: kvm@xxxxxxxxxxxxxxx, Paolo Bonzini <pbonzini@xxxxxxxxxx>, rkrcmar@xxxxxxxxxx
Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 5CA68C04B945
In-reply-to: <20170314133450.13259-17-david@redhat.com>
References: <20170314133450.13259-1-david@redhat.com> <20170314133450.13259-17-david@redhat.com>
User-agent: Mutt/1.5.24 (2015-08-30)

On Tue, Mar 14, 2017 at 02:34:44PM +0100, David Hildenbrand wrote:
> No need for the goto label + local variable "r".
> 
> Signed-off-by: David Hildenbrand <david@xxxxxxxxxx>

Reviewed-by: Peter Xu <peterx@xxxxxxxxxx>

(Maybe setup_routing_entry() can be cleaned up as well?)

-- peterx

Follow-Ups:
- Re: [PATCH v1 16/22] KVM: x86: drop goto label in kvm_set_routing_entry()
  - From: David Hildenbrand

References:
- [PATCH v1 00/22] pic/ioapic/irqchip cleanups + minor fixes
  - From: David Hildenbrand
- [PATCH v1 16/22] KVM: x86: drop goto label in kvm_set_routing_entry()
  - From: David Hildenbrand

Prev by Date: Re: [patch 0/3] KVM CPU frequency change hypercalls (resend)
Next by Date: Re: [PATCH v1 17/22] KVM: x86: simplify pic_unlock()
Previous by thread: [PATCH v1 16/22] KVM: x86: drop goto label in kvm_set_routing_entry()
Next by thread: Re: [PATCH v1 16/22] KVM: x86: drop goto label in kvm_set_routing_entry()
Index(es):
- Date
- Thread

[Index of Archives] [KVM ARM] [KVM ia64] [KVM ppc] [Virtualization Tools] [Spice Development] [Libvirt] [Libvirt Users] [Linux USB Devel] [Linux Audio Users] [Yosemite Questions] [Linux Kernel] [Linux SCSI] [XFree86]

Powered by Linux